[await-dictionary] add failure case and edge case tests by danialasaria · Pull Request #5041 · tc39/test262

danialasaria · 2026-04-29T17:58:34Z

Summary

This PR adds the remaining failure-case and edge-case coverage for the await-dictionary proposal's Promise keyed combinators:

Promise.allKeyed
Promise.allSettledKeyed

It follows the runtime/behavioral tests PR (#4932) and completes the testing plan from #4886.

What this PR covers

NewPromiseCapability failures (sync throws)

Constructor body throws (ctx-ctor-throws.js)
Executor does not provide callable resolve/reject in various combinations (capability-executor-not-callable.js)

GetPromiseResolve failures (async rejections)

Get(constructor, "resolve") accessor throws (invoke-resolve-get-error-reject.js)
Calling the resolved promiseResolve function throws (invoke-resolve-error-reject.js)

Invoke(then) failures (async rejections)

Get(nextPromise, "then") accessor throws (invoke-then-get-error-reject.js)
Calling nextPromise.then(...) throws (invoke-then-error-reject.js)

allKeyed rejection ordering

Second promise to settle is rejected (reject-second.js)
Last promise to settle is rejected (reject-last.js)

Synchronous thenables (step 8 edge case)

Thenables that synchronously invoke onFulfilled during the loop, causing remainingElementsCount to reach zero before the loop exits (resolve-before-loop-exit.js)

Exotic object abrupt completions (Proxy)

[[OwnPropertyKeys]] throws (ownkeys-throws.js)
[[GetOwnProperty]] throws (getownproperty-throws.js)
[[GetOwnProperty]] returns undefined -- key is skipped (getownproperty-returns-undefined.js)

Property descriptor filtering

Non-enumerable keys are skipped (getownproperty-not-enumerable.js)

Notes

All async tests use asyncTest from asyncHelpers.js per reviewer feedback on [await-dictionary] add runtime keyed Promise combinator tests #4932
Sync tests use assert.throws(...)
All tests are feature-gated with features: [await-dictionary]; Proxy tests additionally gate on Proxy
Tests mirror existing patterns from Promise.all / Promise.allSettled test suites
capability-executor-not-callable includes poisoned resolve getters (matching Promise.all counterpart) to detect wrong evaluation order

What this PR does not cover

This completes all items from the testing plan (#4886).

References

Testing plan issue: Promise.allKeyed and Promise.allSettledKeyed testing plan #4886
Prior runtime tests PR: [await-dictionary] add runtime keyed Promise combinator tests #4932
Prior boilerplate PR: [await-dictionary] add boilerplate tests for Promise.allKeyed and Promise.allSettledKeyed #4927
Proposal text: Await Dictionary

acutmore

Could we also have a test that a custom constructor is being 'constructed' rather than 'called'.

If we can use new.target we can check like:

var error = new Test262Error();
function Constructor(executor) {
  if (new.target !== Constructor) {
    throw error
  }
}

We can also have assertions that validate the arguments passed to a custom constructor are correct: should only be one argument: the executor. And it should be a function with length 2.

acutmore · 2026-05-01T16:59:00Z

+
+Promise.allSettledKeyed.call(Constructor, input);
+
+assert.sameValue(callCount, 1, "callCount after call to allSettledKeyed()");


Could we either move the callCount to after the assertions, or have a separate count for the start and end of the callback. Otherwise technically the assertions could reject and they are swallowed by the function caller yet the test would pass (unless the harness has some tracking logic to guarantee a test fails if a harness assertion errors, rather than relying on the exception bubbling up)

Fixed by replacing the single counter with resolveStartCount and resolveEndCount. The end counter is incremented only after the resolve callback assertions complete, so an assertion failure inside the callback won’t be hidden by the final count check.

Cover remaining items from the testing plan (tc39#4886): - NewPromiseCapability: constructor throws, executor not callable - NewPromiseCapability: validate Construct (new.target, executor arity) - GetPromiseResolve: Get accessor throws, promiseResolve call throws - Invoke(then): Get accessor throws, call throws - allKeyed rejection ordering (2nd and last to settle) - Synchronous thenables hitting remainingElementsCount step 8 - Exotic object: [[OwnPropertyKeys]] throws - Exotic object: [[GetOwnProperty]] throws / returns undefined - Property descriptor filtering: non-enumerable keys skipped

acutmore · 2026-05-14T13:26:06Z

+  ownKeys: function() {
+    return ['key'];
+  },


not harmful but also feels superfluous to the test as ownKeys will already be returning this.

Removed the explicit ownKeys trap. The Proxy target already has an own enumerable key property, so default [[OwnPropertyKeys]] still exposes the key while the test remains focused on the custom getOwnPropertyDescriptor behavior.

I'm still seeing the ownKeys trap. Did you forget to push?

acutmore · 2026-05-14T13:26:50Z

+  ownKeys: function() {
+    return ['key'];
+  },


Same comment as: https://github.com/tc39/test262/pull/5041/changes#r3241633686

Fixed here as well--removed the redundant ownKeys trap

danialasaria · 2026-05-29T14:46:51Z

Could we also have a test that a custom constructor is being 'constructed' rather than 'called'.

If we can use new.target we can check like:
var error = new Test262Error();
function Constructor(executor) {
  if (new.target !== Constructor) {
    throw error
  }
}
We can also have assertions that validate the arguments passed to a custom constructor are correct: should only be one argument: the executor. And it should be a function with length 2.

Added ctx-ctor-constructed.js coverage for both Promise.allKeyed and Promise.allSettledKeyed. The custom constructor checks new.target, verifies it receives exactly one argument, confirms the executor is callable, and asserts executor.length === 2.

…tests

Ms2ger

Didn't get through it yet, but here are some initial comments.

Ms2ger

Please address the previous comments in the analogous allSettledKeyed tests as well.

Ms2ger · 2026-06-03T13:59:16Z

+  ownKeys: function() {
+    return ['key'];
+  },


I'm still seeing the ownKeys trap. Did you forget to push?

Add missing feature metadata, align Invoke(then) spec excerpts, and remove redundant ownKeys traps from getOwnProperty tests.

danialasaria · 2026-06-03T16:02:54Z

Please address the previous comments in the analogous allSettledKeyed tests as well.

Should be all updated now!

Add assertion messages for getOwnProperty tests where skipped keys produce an empty result object.

danialasaria mentioned this pull request Apr 29, 2026

[await-dictionary] add failure case and edge case tests danialasaria/test262#1

Closed

danialasaria force-pushed the dasaria/await-dictionary-keyed-failure-edge-tests branch from 578f02d to 6e2fa0c Compare April 29, 2026 18:05

danialasaria marked this pull request as ready for review April 29, 2026 18:11

danialasaria requested a review from a team as a code owner April 29, 2026 18:11

acutmore reviewed May 1, 2026

View reviewed changes

ptomato added the needs review label May 6, 2026

danialasaria force-pushed the dasaria/await-dictionary-keyed-failure-edge-tests branch from 6e2fa0c to 85ec0d4 Compare May 9, 2026 22:14

acutmore reviewed May 14, 2026

View reviewed changes

danialasaria requested a review from acutmore May 29, 2026 14:47

Merge branch 'main' into dasaria/await-dictionary-keyed-failure-edge-…

b685280

…tests

Ms2ger reviewed Jun 2, 2026

View reviewed changes

Ms2ger self-assigned this Jun 2, 2026

Ms2ger approved these changes Jun 3, 2026

View reviewed changes

[await-dictionary] address keyed test review comments

32844d7

Add missing feature metadata, align Invoke(then) spec excerpts, and remove redundant ownKeys traps from getOwnProperty tests.

danialasaria requested a review from Ms2ger June 3, 2026 16:02

[await-dictionary] clarify empty result assertions

2d18ef3

Add assertion messages for getOwnProperty tests where skipped keys produce an empty result object.

Ms2ger merged commit 05bb032 into tc39:main Jun 4, 2026
9 of 14 checks passed

lahma mentioned this pull request Jun 7, 2026

Update test262 suite and fix promise combinator non-thenable handling sebastienros/jint#2500

Merged

acutmore mentioned this pull request Jun 25, 2026

Promise.allKeyed and Promise.allSettledKeyed testing plan #4886

Open

33 tasks


		Promise.allSettledKeyed.call(Constructor, input);

		assert.sameValue(callCount, 1, "callCount after call to allSettledKeyed()");

Uh oh!

Conversation

danialasaria commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What this PR covers

NewPromiseCapability failures (sync throws)

GetPromiseResolve failures (async rejections)

Invoke(then) failures (async rejections)

allKeyed rejection ordering

Synchronous thenables (step 8 edge case)

Exotic object abrupt completions (Proxy)

Property descriptor filtering

Notes

What this PR does not cover

References

Uh oh!

acutmore left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danialasaria commented May 29, 2026

Uh oh!

Ms2ger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ms2ger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danialasaria commented Jun 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

danialasaria commented Apr 29, 2026 •

edited

Loading